Original post: hachyderm.io (Mastodon)
So we need to be careful with upper- and lowercase. Meanwhile the docs: > settiings
Yes, the settiings are different than the settings. You also need to be careful with those.
had to use a different spelliings at backend and frontend, otherwise it wouldn’t work.
Is the backend Python and the frontend JavaScript? Because then that would happen and just be normal, because Boolean true is
Truein python.Probably, but if you’re interpreting user inputs as raw code, you’ve got much much worse problems going on, lol.
Given the warning about capitalization, the best possible case is that they’re using ast.literal_eval() rather than throwing untrusted input into
eval().Err, I guess they might be comparing strings to ‘True’ and are choosing to be really strict about capitalization for some reason.
Yeah. Maybe .to_lower() is really expensive in their environment, lol.
[...]®ister=import os; os.system("sudo rm -rf /"); return TrueHey, that’s my username too. Or it was going to be, while the site was still up.
What a coincidence!
I guess I’ll wait for the site to come back, and see if it’s still available…
It’s the settiings file… It’s probably supposed to only be written by the system admin.
A good place to put persistent malware. That’s why when using docker images always mount as ro if at all possible.
It’s you can modify the settings file you sure as hell can put the malware anywhere you want
Every environment has plenty of good places to put persistent malware. Even if you run your docker images as ro.
It’s not User input, it’s config file
Can’t they just convert a “true” input to backend to uppercase
Yep they should use a config file format like JSON or TOML or YAML or what have you, and then decode that into python objects. Using an actual programming language for config is dumb as hell IMO. (inb4 pissed off suckless fans)
I refer you to #7 on Bruce Tognazzini’s evergreen top ten list of design bugs.
Depends on how it’s set up. If the setting is going into the env it’s a string, so I’d expect some sort of
if os.getenv("this_variable", "false").lower() == "true": # or maybe "in true, yes, on, 1" if you want to be weird like yaml this_variable = True else: this_variable = FalseExcept maybe a little more elegant and not typed on my phone.
But if the instructions are telling the user to edit the settings directly, like where I wrote this_variable=True, they’d need to case it correctly there.
Searching for the phrase, documentation matches for Taiga so maybe you’re right!
deleted by creator
That makes me think, perhaps, you might be able to set it to
exec("stuff") or True…The cherry on top is that they didn’t even spell settings correctly.
settiings is spelled differently on the backend
Hear me out, what about using JSON to store the configuration in the Python backend?
I like your idea, but hear me out:
A Python file for configuration is the best way to guarantee that any friendly code I write to help the user with config usually won’t execute. And I hate my users.
You need to use as many different formats as possible, otherwise you look unprofessional
But if it needs to be both why the case difference?
Different programming languages for frontend and backend
Oh duh, I was thinking this was in some configuration where they were set under the same line.
different languages I presume
