• xmunk@sh.itjust.works
    82·
    2 years ago

    I disagree.

    Be…before I go. Could you approve all my experimental PRs?

    Real story, I have a branch that’s been open for four years at my company to add support for nested postgres transactions. It works flawlessly… but we, the senior devs, are uncertain if it’s a power that would be used responsibly by the juniors. If I’m going to walk into the light, I’m going to make sure there’s a badass explosion behind me.

    • eluvatar@programming.dev
      11·
      2 years ago

      I’ve got one for a vscode feature (middle mouse click for go-to definition) that I want but the maintainers don’t think it would be used.

      • Opisek@lemmy.world
        8·
        2 years ago

        I’m in the niche of niches by using vsc with a vim plugin while being a dvorak user. I rely on vim’s langmap feature to get anywhere, but people implementing vim emulators blissfully ignore accessibility like that. So I went and implemented langmap in vsc’s vim plugin myself. It has minimal intervention into the existing codebase and a bunch of other people have been wishing for this for years. Yet, when it comes to merging… Silence.

        • eluvatar@programming.dev
          4·
          2 years ago

          Can’t you just open source your fork? I mean yeah it does suck but still. I’ve been in the same place and it does suck when they won’t take your PR.

  • drolex@sopuli.xyz
    49·
    2 years ago

    You haven’t written your unit tests and you have 675 compiling errors left. It’s time to sleep grandpa

  • _dev_null@lemmy.zxcvn.xyz
    342·
    2 years ago

    That’s why I’ve got my IDE configured to make a commit and push for every single ctrl-s.

    And one more thing, I’m not going to squash before my final PR.

    EDIT:

    For those of you interested, here’s my gitconfig alias to help with this workflow:

    [alias]
    ctrl-s-commit-push="!f() { count=$(cat count.txt); git add .; git commit -m \"$(date): commit $count\"; git push;}; f"

    IMPORTANT: For those who are downvoting, yes, my entire comment is sarcasm, lol! Do not ever do anything like this in a shared repo, ever! If you actually do this in a shared repo, your access will likely be revoked the moment someone sane and competent realizes what you’re doing.

    Addendum: In that alias, I would’ve used left angle bracket instead of cat, but apparently lemmy scrubs those. I even tried the entity for it, but no go for either.