Kissaki@programming.dev to Programming@programming.devEnglish · 2 days agoThe Pain That is GitHub Actions - Feldera Blogwww.feldera.comexternal-linkmessage-square20fedilinkarrow-up137arrow-down19
arrow-up128arrow-down1external-linkThe Pain That is GitHub Actions - Feldera Blogwww.feldera.comKissaki@programming.dev to Programming@programming.devEnglish · 2 days agomessage-square20fedilink
minus-squareFizzyOrange@programming.devlinkfedilinkarrow-up3arrow-down1·10 hours agoTo check that people ran the pre-commit linters. Committing itself won’t be possible That’s not how pre-commit hooks work. They’re entirely optional and opt-in. You need CI to also run them to ensure people don’t forget.
minus-squarelemmeBe@sh.itjust.workslinkfedilinkarrow-up1arrow-down2·8 hours agoThey’re optional if you make them optional. I didn’t. You do as you please. 😄
minus-squareFizzyOrange@programming.devlinkfedilinkarrow-up2·8 hours agoNo, they’re inherently optional in Git. There’s no way to “check in” a git hook. You have to put in your README Clone the repo and then please run pre-commit install! Oh and whatever you do don’t git commit --no-verify! You definitely need to actually check the lints in CI. It’s very easy though, just add pre-commit run -a to your CI script.
To check that people ran the pre-commit linters.
That’s not how pre-commit hooks work. They’re entirely optional and opt-in. You need CI to also run them to ensure people don’t forget.
They’re optional if you make them optional. I didn’t. You do as you please. 😄
No, they’re inherently optional in Git. There’s no way to “check in” a git hook. You have to put in your
READMEYou definitely need to actually check the lints in CI. It’s very easy though, just add
pre-commit run -ato your CI script.