• Kryomaani@sopuli.xyz
          link
          fedilink
          English
          arrow-up
          18
          arrow-down
          1
          ·
          1 year ago

          Which is exactly why you shouldn’t be using them in a situation that clearly calls for a switch.

          • Serdan@lemm.ee
            link
            fedilink
            English
            arrow-up
            5
            arrow-down
            1
            ·
            edit-2
            1 year ago

            In the given example I’d probably use a switch / match expression, but ternaries are usually more flexible than switches and I don’t think it’s an issue to write a nested ternary instead of if else statements.

            • lowleveldata@programming.dev
              link
              fedilink
              English
              arrow-up
              4
              arrow-down
              2
              ·
              edit-2
              1 year ago

              ternaries are usually more flexible than switches

              Which is bad for readability because the reader need to manually compute it to see whether it’s doing simple switching or not. Also it adds the question of “Why did the author use a nested ternary instead of a switch? Was it meant to do more but it got left out unintentionally?”

              • Serdan@lemm.ee
                link
                fedilink
                English
                arrow-up
                3
                arrow-down
                2
                ·
                1 year ago

                Yes, you need to read code to understand it. If else statements can also do the job of a switch, so the exact same argument applies.

    • deaf_fish@lemm.ee
      link
      fedilink
      arrow-up
      1
      arrow-down
      1
      ·
      1 year ago

      There is usually a safer and more readable way to do what you want to do by chaining ternaries in most languages.

        • deaf_fish@lemm.ee
          link
          fedilink
          arrow-up
          2
          arrow-down
          1
          ·
          edit-2
          1 year ago

          Well, if you assume ternary operations work the same in PHP as in c and attempted to write the code demoed by this meme. You would end up with unexpected behavior. Maybe I should have said unexpected behavior instead of unsafe behavior.

          • Serdan@lemm.ee
            link
            fedilink
            arrow-up
            2
            arrow-down
            1
            ·
            1 year ago

            PHP is the only language in existence with a left associative ternary operator. Ignoring PHP, the operator has worked exactly the same way for decades. And even PHP has now fixed the operator.

            I don’t think it’s reasonable to avoid a very commonly supported pattern just because a single badly designed language implemented it wrong.

            • deaf_fish@lemm.ee
              link
              fedilink
              arrow-up
              2
              arrow-down
              1
              ·
              1 year ago

              Okay, even if I give you the unexpected behavior point. The readability problem remains. Switch statements or tables will work just fine and are easier to read.

              To be clear, I am fine with single ternary operations. I think nested ternary operations are harder to read and follow.

              • Serdan@lemm.ee
                link
                fedilink
                arrow-up
                1
                ·
                1 year ago

                I agree you should use a switch where applicable, but ternaries are the expression equivalent of if-else statements. If I have two conditions and a default, and each branch simply evaluates to a value of the same type, I’ll probably just use a ternary.